Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient storage implementation #31

Closed
wants to merge 6 commits into from

Conversation

Debugger022
Copy link
Contributor

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@Debugger022 Debugger022 marked this pull request as ready for review December 9, 2024 10:33
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 18% 28%
Summary 18% (15 / 85) 28% (9 / 32)

package.json Outdated
@@ -66,7 +66,7 @@
"eslint-plugin-prettier": "3.4.1",
"eslint-plugin-promise": "^5.2.0",
"ethers": "^5.7.0",
"hardhat": "^2.16.1",
"hardhat": "2.19.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using ^2.22.15 in the vips repo. Could we upgrade this to that version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, 74217d1

@@ -38,7 +38,7 @@ const config: HardhatUserConfig = {
enabled: true,
runs: 200,
},
evmVersion: "paris",
evmVersion: "cancun",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support:

AFAIU, ZKSync era doesn't support transient storage yet:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZKsync Era supports transient storage. Confirmed with the team

@Debugger022 Debugger022 force-pushed the feat/transient-storage branch from 3a5bcdf to 0d40a43 Compare December 12, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants